Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Id Pagination #213

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Add Id Pagination #213

merged 2 commits into from
Nov 13, 2023

Conversation

macanudo527
Copy link
Collaborator

What? Why?

Part of #200.

Id pagination must be implemented to pull data from BitGet. Id pagination is also required for other exchanges. This includes implementation as well as tests.

FYI
Since I'm quite busy these days. I'll be implementing the BitGet issue piecemeal.

@macanudo527 macanudo527 self-assigned this Nov 7, 2023
@macanudo527 macanudo527 marked this pull request as draft November 7, 2023 23:48
@macanudo527 macanudo527 force-pushed the add_bitget branch 2 times, most recently from 0c794db to 39543c8 Compare November 8, 2023 00:10
@macanudo527 macanudo527 marked this pull request as ready for review November 8, 2023 02:19
Copy link
Owner

@eprbell eprbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good: piecemeal implementations are better than monolithic ones because they're easier to review.

@eprbell eprbell merged commit 92a35a7 into eprbell:main Nov 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants