Implement forex python

[macanudo527]

What?

Fixes #224
Dependent on #223
This allows users to make use of CSV files for Forex pricing instead of rely on exchangerate.host

Testing

I have not tested this with real world data at all. This is curently WIP.

[macanudo527]

@eprbell this reads in missing forex data from CSV files. But, I did finally find this API that can basically do the same thing, but via a REST API. Should I keep both and use the CSV files as a fallback?

[eprbell]

@eprbell this reads in missing forex data from CSV files. But, I did finally find this API that can basically do the same thing, but via a REST API. Should I keep both and use the CSV files as a fallback?

Sounds good, but should it be a separate plugin, so that the user can decide which to use and with what priority?

[macanudo527]

Sounds good, but should it be a separate plugin, so that the user can decide which to use and with what priority?

I'm wondering about how to implement that. Maybe have two different CCXT pair converters one with the REST API, and one with the importing of CSV?

[eprbell]

Sounds good, but should it be a separate plugin, so that the user can decide which to use and with what priority?

I'm wondering about how to implement that. Maybe have two different CCXT pair converters one with the REST API, and one with the importing of CSV?

Yes, that's what I was thinking: that should give the user the most flexibility.

[macanudo527]

@eprbell btw, I'm going to try to cherry pick and splice the code from your PR. Hopefully, I can get it all put together here soon.

Should I implement this with inheritance, or by parameter that will load a particular class to handle forex processing? I'm thinking making ccxt pair converter abstract and the forex processing has to inherit from it. OR, make the REST API default, and then have another CSV class inherit and override the defaults.

[eprbell]

@eprbell btw, I'm going to try to cherry pick and splice the code from your PR. Hopefully, I can get it all put together here soon.

Sounds good, no worries.

Should I implement this with inheritance, or by parameter that will load a particular class to handle forex processing? I'm thinking making ccxt pair converter abstract and the forex processing has to inherit from it. OR, make the REST API default, and then have another CSV class inherit and override the defaults.

I'm leaning toward making the ccxt-based converter abstract and have the two forex processing plugins inherit from it. In theory we could do something similar to the input plugins and have csv and rest subdirectories, but that would not be backward compatible, would require changes in users config files, and would make this change more complex: let's leave it as is. If needed, we'll tackle that issue as a separate change later.

[macanudo527]

@eprbell This should fix most Forex Issues. It is lacking docs, but I thought I would let you get a peek at it.

[eprbell]

@eprbell This should fix most Forex Issues. It is lacking docs, but I thought I would let you get a peek at it.

Sounds good: I'll take a look (the diff in Github is large so it may take some time for me to go through it).

[macanudo527]

Sounds good: I'll take a look (the diff in Github is large so it may take some time for me to go through it).

I figured it would take a while. I tried to figure out a way to break down into simpler parts, but kind of just had to be done all at once. Sorry.