Fix aria-describedby for one-itemref/dataobjref components #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where MetaField::Itemref ignores $one_field_component, meaning an incorrect value for aria-describedby is applied when an Itemref is the only field in a component.
Fix issue where MetaField::Dataobjref ignores $one_field_component, meaning an incorrect value for aria-describedby is applied when a Dataobjref is the only field in a component.
|
Thanks Alex. As you say some fields are more difficult to test than others. As non-multiple itemref/dataobjref are not used in a vanilla EPrints install, the issue with aria-describedby not lining up with the ID for the help div got missed. I did take some time trying to deal with the rather inconsistent values for help div IDs, which caused a lot of problems and led to the need for this $one_field_component parameter. I will review you patches to confirm they fix the issue you describe on my development/test instance of ePrints before accepting the pull request. I will also look into whether I can test the Multipart field as well. |
drn05r
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an itemref or dataobjref field is the only field in a workflow component, the
aria-describedbyproperty is set to "c[number]_help_[name]" rather than "c[number]_help", because the$one_field_componentvalue is not being passed on toEPrints::MetaField->get_describedby.This PR adds support for
$one_field_componentto these two MetaField classes.The same issue may affect
EPrints::MetaField::Multipart->get_basic_input_elementsbut it is currently awkward for me to test this.