Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aria-describedby for one-itemref/dataobjref components #153

Merged
merged 2 commits into from Jun 23, 2021
Merged

Fix aria-describedby for one-itemref/dataobjref components #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c30c19
Add missing support for $one_field_component in Itemref
alex-ball Jun 23, 2021
64b811d
Add missing support for $one_field_component in Dataobjref
alex-ball Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions perl_lib/EPrints/MetaField/Dataobjref.pm
View file
Open in desktop
Expand Up @@ -60,9 +60,9 @@ sub get_property_defaults

sub get_basic_input_elements
{
my( $self, $session, $value, $basename, $staff ) = @_;
my( $self, $session, $value, $basename, $staff, $obj, $one_field_component ) = @_;

my $ex = $self->SUPER::get_basic_input_elements( $session, $value, $basename, $staff );
my $ex = $self->SUPER::get_basic_input_elements( $session, $value, $basename, $staff, $obj, $one_field_component );

# my $desc = $self->render_single_value( $session, $value );

Expand Down Expand Up @@ -174,9 +174,9 @@ sub dataobj

sub get_input_elements
{
my( $self, $session, $value, $staff, $obj, $basename ) = @_;
my( $self, $session, $value, $staff, $obj, $basename, $one_field_component ) = @_;

my $input = $self->SUPER::get_input_elements( $session, $value, $staff, $obj, $basename );
my $input = $self->SUPER::get_input_elements( $session, $value, $staff, $obj, $basename, $one_field_component );

# my $buttons = $session->make_doc_fragment;
# $buttons->appendChild(
Expand Down
8 changes: 4 additions & 4 deletions perl_lib/EPrints/MetaField/Itemref.pm
View file
Open in desktop
Expand Up @@ -50,9 +50,9 @@ sub get_property_defaults

sub get_basic_input_elements
{
my( $self, $session, $value, $basename, $staff ) = @_;
my( $self, $session, $value, $basename, $staff, $obj, $one_field_component ) = @_;

my $ex = $self->SUPER::get_basic_input_elements( $session, $value, $basename, $staff );
my $ex = $self->SUPER::get_basic_input_elements( $session, $value, $basename, $staff, $obj, $one_field_component );

my $desc = $self->render_single_value( $session, $value );

Expand Down Expand Up @@ -116,9 +116,9 @@ sub get_item

sub get_input_elements
{
my( $self, $session, $value, $staff, $obj, $basename ) = @_;
my( $self, $session, $value, $staff, $obj, $basename, $one_field_component ) = @_;

my $input = $self->SUPER::get_input_elements( $session, $value, $staff, $obj, $basename );
my $input = $self->SUPER::get_input_elements( $session, $value, $staff, $obj, $basename, $one_field_component );

my $buttons = $session->make_doc_fragment;
$buttons->appendChild(
Expand Down