Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CitationCache code to use EPrints API rather than SQL query #370

Closed
drn05r opened this issue Feb 1, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@drn05r
Copy link
Contributor

drn05r commented Feb 1, 2024

The following line was original written as SQL for expediency and should have be modified to use the EPrints API once the correct query was determined.

my $citations_sql = "SELECT `citationcacheid`, `citation_text`, `timestamp_year` AS `year`, `timestamp_month` AS `month`, `timestamp_day` AS `day`, `timestamp_hour` AS `hour`, `timestamp_minute` AS `minute`, `timestamp_second` AS `second` FROM `citationcache` WHERE `datasetid` = '" . $self->{dataset}->confid . "' AND `objectid` = '" . $self->id . "' AND `style` = '" . $style . "' ORDER BY `timestamp_year`, `timestamp_month`, `timestamp_day`, `timestamp_hour`, `timestamp_minute`, `timestamp_second` DESC LIMIT 1";

@drn05r drn05r added the enhancement New feature or request label Feb 1, 2024
@drn05r drn05r added this to the 3.4.6 milestone Feb 1, 2024
@drn05r drn05r self-assigned this Feb 1, 2024
@drn05r drn05r changed the title Rewrite CitationCache code to use EPrints API ratherthan SQL query Rewrite CitationCache code to use EPrints API rather than SQL query Feb 1, 2024
@drn05r drn05r closed this as completed in 0702d64 Feb 5, 2024
@drn05r drn05r reopened this Feb 26, 2024
@drn05r
Copy link
Contributor Author

drn05r commented Feb 26, 2024

Also fix EPrints::DataObj::clear_citationcaches function to use EPrints API.

drn05r added a commit that referenced this issue Feb 26, 2024
@drn05r drn05r closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant