Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod-perl handling: HTTP/1.1 404 should be 500 if the document is there and readable but database queries fail #375

Closed
UmbrellaDish opened this issue Feb 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@UmbrellaDish
Copy link

Let's suppose you have prepared for an update of your EPrints archive on a development machine. Everything works and before you switch domains to you productive public IP you go fetch an up-to-date fresh database dump from your productive old machine. Unfortunately you forget to update the database anew with epadmin update. So your refreshed database still is in the schema of version 3.4.2 that lacks a number of fields.

You try to retrieve a document ... 404.

Why the response code is not 500 Internal Server Error / EPrints System Error which I think would be more correct in this situation? It seems database errors are not handled properly. The apache mod-perl handler certainly looks up the database to ensure the requesting client is authenticated and/or authorized to access the (cached) document file that is actually present and readable by the webserver.

I would humbly second for a proper distinction between 404 NOT FOUND and 500 INTERNAL SERVER ERROR i.e. "error retrieving the authorization status of the client: query failed" logged. That distinction would have simplified my search at least.

@drn05r drn05r self-assigned this Feb 23, 2024
@drn05r drn05r added this to the 3.4.6 milestone Feb 23, 2024
@drn05r drn05r added the bug Something isn't working label Feb 23, 2024
@drn05r drn05r closed this as completed in 4866f56 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants