Encode field values sent in autocompleter requests #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autocompleting a compound field, the parameters sent include the value of the active field and the values of all the component fields. Currently, the value of the active field is URI-encoded but the other values are not. Let's say the creators field has as affiliation subfield: ``` q=Example%20College%3B%20University &name_family=Smith &name_given=Sam &affiliation=Example College; University ``` This is normally harmless since few characters cause issues in this context and unescaping occurs before the values reach the processing script. However, in CGI.pm v2.64+, the semicolon is treated as an alias for ampersand and therefore terminates the value. This means when using `$session->param` we get ``` q => 'Example%20College%3B%20University', affiliation => 'Example College' ``` This PR adds URI encoding to the field values added by the `ep_autocompleter` callback so they are handled equivalently to the `q` parameter.
drn05r
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autocompleting a compound field, the parameters sent include the value of the active field and the values of all the component fields. Currently, the value of the active field is URI-encoded but the other values are not. Let's say the creators field has an affiliation subfield:
This is normally harmless since few characters cause issues in this context and unescaping occurs before the values reach the processing script. However, in CGI.pm v2.64+, the semicolon is treated as an alias for ampersand and therefore terminates the value. This means when using
$session->paramwe getThis PR applies URI encoding to the field values added by the
ep_autocompletercallback so they are handled equivalently to theqparameter.