Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider a 3-tuple return value as an exception #113

Merged
merged 1 commit into from Nov 12, 2013
Merged

Do not consider a 3-tuple return value as an exception #113

merged 1 commit into from Nov 12, 2013

Conversation

lucafavatella
Copy link
Contributor

Use an additional parameter in meck_proc:add_history for explicitly
specifying whether the entry added in the history is supposed to be an
exception ('x') or a normal return value of a function call ('c').

Use distinct functions 'add_history_exception' and 'add_history' for
explicitly specifying whether the entry added in the history is
supposed to be an exception or a normal return value of a function
call.
@lucafavatella
Copy link
Contributor Author

Instead of making a flag in the form of x or c, can you make two different functions?

add_history_exception(...) ->
add_history_call(...) ->

Hi Adam,

I integrated your feedback updating (push force) the pull request.

Regards
Luca

eproxus added a commit that referenced this pull request Nov 12, 2013
…-returning-tuple-3

Do not consider a 3-tuple return value as an exception
@eproxus eproxus merged commit 8a9007c into eproxus:master Nov 12, 2013
@eproxus
Copy link
Owner

eproxus commented Nov 12, 2013

Thanks! Merged!

@lucafavatella lucafavatella deleted the feature/fix-history-for-fn-returning-tuple-3 branch November 12, 2013 09:46
@eproxus eproxus added the bug label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants