Allow hiding 'on_load' attribute. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hide_on_load() -> | ||
| % We _don't_ want on_load to be called. Listen out for it. | ||
| register(on_load_listener, self()), | ||
| meck:new(meck_on_load_module, [passthrough, hide_on_load]), |
There was a problem hiding this comment.
If you remove hide_on_load, then make test fails with the following:
meck_on_load_tests: on_load_test_...*failed*
in function meck_on_load_tests:hide_on_load/0 (test/meck_on_load_tests.erl, line 21)
**error:unexpected_call_to_on_load
|
Hi, thank you so much for the PR. I'm not really a fan of the name
I particularly like the second one because it also signals that it has something to do with the backup modules. |
|
I prefer the first one. I don't think that people writing the test particularly care about backup or not. They just don't want Except that |
|
Agree, double-negatives are bad. Would you mind changing to |
eproxus
added a commit
that referenced
this pull request
Nov 25, 2014
Allow hiding 'on_load' attribute.
|
Again, thanks a lot! |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #130.