Update meck for OTP 18.0 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| %% Compiler Options =========================================================== | |||
| {erl_opts, [ | |||
| %% Erlang releases after 17 don't put R in front of their name, and also require dict() to be written like dict:dict() | |||
| {platform_define, "^[0-9]+", namespaced_dicts}, | |||
| {platform_define, "^[0-9]+", namespaced_types}, | |||
There was a problem hiding this comment.
Was there a functional reason for renaming namespaced_dicts to namespaced_types? (Apart from that it looks better?) 😄
There was a problem hiding this comment.
yeah, it does look a bit better :) but this is actually needed for meck_tests.erl to compile in 18.0 (those non-namespaced types are completely removed now). I tried to explain it in the commit message but let me know if I should make it clearer.
There was a problem hiding this comment.
Ah, you mean the define is needed, and the new name better describes it (because it is more general)? If so, then keep the change. 😄
added 2 commits
March 31, 2015 21:01
Meck used to have 'namespaced_dict' while Hamcrest recently introduced a similar macro, 'namespaced_types' for the same purpose. In OTP 18.0 the affected non-namespaced types were completely removed and using them results in a compile error instead of deprecation wagning in 17. So hamcrest.hrl relies on the precense of 'namespaced_types' macro to use the right type. Meck's test module meck_tests.erl includes this header so the 'namespaced_types' macro also have to be defined in meck's test.config. To eliminate duplication I chose to unite the above two macros and use the more generic 'namespaced_types' name.
In order to avoid creating temporary files meck_cover needs direct access to some unexported functions of cover. In OTP 18.0 the internal API of cover changed a bit and compile_beam/2 (which allows passing a binary instead just a filename) was replaced by compile_beams/1. See erlang/otp@ab435488
gomoripeti
force-pushed
the
fix-cover-otp-18.0
branch
from
6949836
to
e3c9d24
Compare
|
updated the code as agreed and extended the description of commit msq gomoripeti/meck@79cb5c9 |
|
Brilliant, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid creating temporary files meck_cover needs direct
access to some unexported functions of cover.
In OTP 18.0 the internal API of cover changed a bit and
compile_beam/2 (which allows passing a binary instead just a filename)
was replaced by compile_beams/1.
See erlang/otp@ab435488
Travis does not have OTP 18.0-rc1 yet but the unit tests pass on my machine
(with the namespaced types change)