Add merge_expects option to meck_proc #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for not getting back to you earlier! Code looks nice and simple! Can you also add a description of the option to the EDoc documentation? |
|
Done! I accept suggestions for a better description :) |
|
How about this?
|
The expectations are merged for the function/arity instead of replacing the existing one
|
Done! |
|
Thank you! |
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expectations are merged for the function/arity instead of replacing the existing one
This is my first try to add the feature proposed at #152.
I added really basic tests to ensure some of the existing expectations are being handled as expected (no pun intended).
Should I add more tests for some specific cases? Is
merge_expectsa good option name?