Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eunit compile failure on Erlang 17+ (hamcrest) #161

Merged
merged 1 commit into from
Apr 30, 2016
Merged

Fix eunit compile failure on Erlang 17+ (hamcrest) #161

merged 1 commit into from
Apr 30, 2016

Conversation

marco-m
Copy link
Contributor

@marco-m marco-m commented Apr 30, 2016

This fixes the error:

make test
...
==> meck (eunit)
...
meck/deps/hamcrest/include/hamcrest_internal.hrl:33: type set() undefined
meck/deps/hamcrest/include/hamcrest_internal.hrl:34: type gb_set() undefined
Compiling test/meck_tests.erl failed:
ERROR: eunit failed while processing meck: rebar_abort

and finally lets eunit run (and fail, at least with Erlang 18.3), but at least travis will go one step ahead :-)

@marco-m marco-m changed the title Fix eunit compile failure on Erlang 18+ (hamcrest) Fix eunit compile failure on Erlang 17+ (hamcrest) Apr 30, 2016
@eproxus
Copy link
Owner

eproxus commented Apr 30, 2016

Thanks so much! I had this on my todo list for quite a while now, but didn't realise the fix could be that easy! 😄 The build just failed because of a random Travis CI crash (happens surprisingly often with Erlang builds for some reason). I restarted and now it's fine, all green. ✅

@eproxus eproxus merged commit 1265700 into eproxus:master Apr 30, 2016
@marco-m
Copy link
Contributor Author

marco-m commented Apr 30, 2016

:-)

@eproxus eproxus added the bug label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants