fix #88 #162
Merged
fix #88 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| % dbg:tracer(), | ||
| % dbg:p(all, call), | ||
| % dbg:tpl(meck, []), | ||
| ok = meck:new(mymod_pass, [passthrough, non_strict]), |
There was a problem hiding this comment.
Would it be possible to use the meck_test_module here? Then we wouldn't have to add a new module to tests.
|
Thanks for a very clear patch! Can you do two things? Squash the commits into one and capitalize the commit message, and make sure the code has a max line width of 80? |
yutopp
force-pushed
the
support_passthrough_when_deleting
branch
from
1d1db55
to
77f63da
Compare
|
Thank you very mush for your quick response.
Thanks! |
|
Brilliant! Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #88.
Added
delete/4which has a flag to delete a function even if the module has apassthroughoption. Now, defaultdelete/3doesn't delete a function(replace to a passthrough entry implicitly) if the module has apassthroughoption.Thanks.