Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#215: Change order when adding new clauses #216

Conversation

zsoci
Copy link
Contributor

@zsoci zsoci commented Oct 24, 2020

No description provided.

@zsoci zsoci force-pushed the #215_merge_expects_does_not_work_with_passthrough branch 2 times, most recently from dc0c130 to 2655eb5 Compare October 24, 2020 10:47
Copy link
Owner

@eproxus eproxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and nice change 👍 I have some small concerns.

src/meck_proc.erl Outdated Show resolved Hide resolved
src/meck_proc.erl Outdated Show resolved Hide resolved
src/meck_proc.erl Outdated Show resolved Hide resolved
@zsoci zsoci requested a review from eproxus November 23, 2020 12:00
Do not recompile when passsthrough is set and non_strict is false

Refactor to comply to standards

Add test case

Optimize new expects creation
@zsoci zsoci force-pushed the #215_merge_expects_does_not_work_with_passthrough branch from 743f817 to 1c2ed87 Compare December 28, 2020 09:32
@eproxus eproxus merged commit 1b63047 into eproxus:master Jan 20, 2021
@eproxus
Copy link
Owner

eproxus commented Jan 20, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants