New features - pid in history and count_calls and wildcard_count_calls functions

[daha]

Hi Adam,

I hacked around a little in meck today and added a few new functions.
I'm wondering if you would be interested in merging my changes.

The main additions is that I added the pids to the history (the output
from meck:history/1 is still like it used to be) and added count_calls
and wildcard_count_calls functions. I have listed the functions below.
I have separe branches for for different "features" if you are not
interested in all the new functions.

• meck:called/4
  • same as meck:called/3 but for a specific pid
• meck:count_calls/3
  • Returns the number of times the specified M:F(A) has been called.
• meck:count_calls/4
  • same as meck:count_calls/3 but for a specific pid
• meck:wildcard_count_calls/3
  • Returns the number of times the specified M:F(A) has been called.
    The wildcard '_' token matches any value.
• meck:wildcard_count_calls/4
  • same as meck:wildcard_count_calls/3 but for a specific pid
• meck:history_with_pid/1
  • Return the internal history, with the pid as the first element in
    the tuple
• meck:history/2
  • same as meck:history/1 but for a specific pid

Best Regards,
David Haglund

[eproxus]

Merged it and added quite a few refactorings on top.

Caution: decided to break the interface instead of adding a bunch of new functions! This is a 0.X version after all.

[daha]

Great!

It looks like good refactorings.

I noticed that you are using match specs so that allows for more variants than just the wildcard token '_'. You can write tests to for instance make sure argument 1 is equal to argument 3, without caring of their exact value.

Example:
Mod:test1(a,b,a),
1 = meck:num_calls(Mod, test1, ['$1', '_', '$1']).

[eproxus]

Ah, true. Need to document that.

I did plan to implement the full match spec interface at some point (allowing guards and return values etc). Something generic, like history_match(Mod, Spec).