Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify history/2 returns events in the correct order & fix to flaky history_by_pid_/1 test #42

Merged
merged 2 commits into from
Oct 13, 2011
Merged

Verify history/2 returns events in the correct order & fix to flaky history_by_pid_/1 test #42

merged 2 commits into from
Oct 13, 2011

Conversation

daha
Copy link
Contributor

@daha daha commented Oct 12, 2011

Hi Adam,

I have made 2 corrections to the test history_by_pid_/1.

  1. Verify that the order of the events in the history is correct
  2. The test was a little flaky, it would fail sometimes (It has happend to me at least once). So I added a receive to wait for the spawned process to make its call.

@daha
Verify that history/2 returns the events in the correct order.
0bf3195
@daha
Fix for the test history_by_pid_/1
8d156e9 
The test could sometimes fail if the spawned process had not made its
call before the assert.
eproxus added a commit that referenced this pull request Oct 13, 2011
@eproxus
Merge pull request #42 from daha/verify-history2-returns-events-in-th…
a0e69e2 
…e-correct-order

Verify history/2 returns events in the correct order & fix to flaky history_by_pid_/1 test
@eproxus eproxus merged commit a0e69e2 into eproxus:master Oct 13, 2011
@eproxus
Copy link
Owner

eproxus commented Oct 13, 2011

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code smell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daha @eproxus