Improved tests: Added an ok in the end of the tests that use a helper function with asserts #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sserts. A failing test, run by foreach, does not show up in the stack trace if it fails in it's last statement and that statement is a call to another function where the asserts are. This is typically the case for all the called_ tests. This can be helped by putting an ok in the end.
|
Thanks, I'll pull this for now. There is another solution to this problem though, which I haven't had time to implement yet. It is to make all the funs in the foreach fully qualified funs (in this case, make them |
eproxus
added a commit
that referenced
this pull request
Oct 13, 2011
…r-functions2 Improved tests: Added an ok in the end of the tests that use a helper function with asserts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Adam,
I made a minor improvement to a few tests by adding an ok at the end.
A failing test, run by foreach, does not show up in the stack trace if
it fails in it's last statement and that statement is a call to
another function where the asserts are. This is typically the case
for all the called_ tests. This can be helped by putting an ok in the
end. This change makes it easier to debug the tests with a helper
function, in the end, since it will tell the name of the test failing.