Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for location included in stack traces in Erlang R15 #52

Merged
merged 1 commit into from
Jan 12, 2012

Conversation

bjnortier
Copy link
Contributor

Support added in the meck:inject/4 function and the unit tests to support the new [{file,},{line,}] information included in stack traces

@eproxus
Copy link
Owner

eproxus commented Jan 7, 2012

Shouldn't the inserted tuple be {Mod, Func, Args, Location} where Location should be a full implementation of the location stack trace item in R15B? When the complete stack trace contains 4-tuples meck should insert one too, I think.

@ghost ghost assigned eproxus Jan 10, 2012
eproxus added a commit that referenced this pull request Jan 12, 2012
Support for location included in stack traces in Erlang R15
@eproxus eproxus merged commit d8b4267 into eproxus:master Jan 12, 2012
@eproxus
Copy link
Owner

eproxus commented Jan 12, 2012

Spoke with the Erlang/OTP team and Erlang should be able to handle the 3-tuples still in all exception code.

It's possible to get the line numbers and file name from the abstract code and I'll see if I can add this to the code so those fields could be filled in too. In either case, this patch will fix the failing tests for no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants