Remove implicit "document" role on body and add it to html (#718)

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
eps1lon · Aug 5, 2021 · 6154760 · 6154760
1 parent 0c2bdea
commit 6154760
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/silver-peas-check.md b/.changeset/silver-peas-check.md
@@ -0,0 +1,5 @@
+---
+"dom-accessibility-api": patch
+---
+
+Remove implicit "document" role on `<body>` and add it to `<html>`
diff --git a/sources/__tests__/getRole.js b/sources/__tests__/getRole.js
@@ -53,7 +53,7 @@ const cases = [
 	["audio", null, createElementFactory("audio", {})],
 	["base", null, createElementFactory("base", {})],
 	["blockquote", null, createElementFactory("blockquote", {})],
-	["body", "document", createElementFactory("body", {})],
+	["body", null, createElementFactory("body", {})],
 	["button", "button", createElementFactory("button", {})],
 	["canvas", null, createElementFactory("canvas", {})],
 	["caption", null, createElementFactory("caption", {})],
@@ -86,7 +86,7 @@ const cases = [
 	["header", "banner", createElementFactory("header", {})],
 	["hgroup", null, createElementFactory("hgroup", {})],
 	["hr", "separator", createElementFactory("hr", {})],
-	["html", null, createElementFactory("html", {})],
+	["html", "document", createElementFactory("html", {})],
 	["iframe", null, createElementFactory("iframe", {})],
 	["img with alt=\"some text\"", "img", createElementFactory("img", {alt: "text"})],
 	["img with missing alt", "img", createElementFactory("img", {})],

diff --git a/sources/getRole.ts b/sources/getRole.ts
@@ -5,7 +5,6 @@ import { getLocalName } from "./util";
 const localNameToRoleMappings: Record<string, string | undefined> = {
 	article: "article",
 	aside: "complementary",
-	body: "document",
 	button: "button",
 	datalist: "listbox",
 	dd: "definition",
@@ -25,6 +24,7 @@ const localNameToRoleMappings: Record<string, string | undefined> = {
 	h6: "heading",
 	header: "banner",
 	hr: "separator",
+	html: "document",
 	legend: "legend",
 	li: "listitem",
 	math: "math",