Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider value attribute before localized input type #406

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Conversation

eps1lon
Copy link
Owner

@eps1lon eps1lon commented Aug 26, 2020

I don't think in

if the current node's native markup provides an attribute (e.g. title) or element (e.g. HTML label) that defines a text alternative

an order was implied but rather deferred to host specific specs such as html-aam.

Closes #405

That section of the code is still quite messy but working.

@eps1lon eps1lon added the bug Something isn't working label Aug 26, 2020
@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2020

🦋 Changeset is good to go

Latest commit: 8a32693

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eps1lon eps1lon merged commit 03273b7 into main Aug 26, 2020
@eps1lon eps1lon deleted the fix/html-aam branch August 26, 2020 19:04
@github-actions github-actions bot mentioned this pull request Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value of input[type=submit] is ignored in determining accessible name
1 participant