This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Remove skip_if_zero in favor of defaulting to it #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches ingame behavor. Stats with 0 value are usually not displayed because they are increased stats usually and therefore dont have any effect.
eps1lon
force-pushed
the
fix-zero-behavior
branch
from
b9f87cd
to
7f58385
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches ingame behavior. Stats with 0 value are usually not displayed because they are increased stats usually and therefore don't have any effect.
This was introduced in #29 as a fallback method but really should be default. Since this isn't released yet we don't have to deprecate the fallback or bump a major version.