This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
fix(patcher.js): rollup does not build dynamic imports #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galbash
reviewed
Dec 7, 2018
src/events/pg.js
Outdated
| const sqlParser = require('node-sqlparser'); | ||
| const pg = tryRequire('pg'); | ||
| const Pool = tryRequire('pg-pool'); | ||
| const sqlParser = tryRequire('node-sqlparser'); |
There was a problem hiding this comment.
This should be a regular require
galbash
reviewed
Dec 8, 2018
| /* eslint-enable import/no-unresolved, import/no-extraneous-dependencies */ | ||
| const sqlParser = require('node-sqlparser'); |
galbash
approved these changes
Dec 9, 2018
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup does not compile dynamic imports (such as tryRequire) in the build.
It means that events/pg was never instrumented.