This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
fix(flask.py): ignore endpoints correctly #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranrib
reviewed
Apr 28, 2021
| if ignored_endpoints: | ||
| self.ignored_endpoints = ignored_endpoints | ||
| if isinstance(ignored_endpoints, list): |
There was a problem hiding this comment.
We can drop this - no one uses this param
There was a problem hiding this comment.
just in case its passed in later on - itll be sure to include it to the std ignored endpoints
There was a problem hiding this comment.
I would prefer to not maintain 2 scenarios just for Flask. It can just lead to confusion / errors. It's better to use the standard way of setting ignored endpoints
maorlx
approved these changes
May 2, 2021
|
🎉 This PR is included in version 1.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.