Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

fix(utils.py): show original import error #364

Merged
merged 3 commits into from
Jul 5, 2021
Merged

Conversation

ranrib
Copy link
Member

@ranrib ranrib commented Jul 5, 2021

Instead of getting this:
Unable to import module 'epsagon': Failed to import module: index
Get this:
Unable to import module 'epsagon': Failed to import module: lambda_function, Error: No module named 'mod'

(this will expose the real import error to the user)

@ranrib ranrib self-assigned this Jul 5, 2021
@ranrib ranrib requested a review from a team as a code owner July 5, 2021 06:05
@ranrib ranrib requested a review from ophiryael July 5, 2021 06:05
@ophiryael
Copy link
Member

The locking of the version might help with the tests but it means that we don't fully support new versions of fastapi and we won't have the same metadata when using newer versions. Maybe it's worth mentioning it in the readme or just fix the issue and ensure we support newer versions.

@ranrib
Copy link
Member Author

ranrib commented Jul 5, 2021

The locking of the version might help with the tests but it means that we don't fully support new versions of fastapi and we won't have the same metadata when using newer versions. Maybe it's worth mentioning it in the readme or just fix the issue and ensure we support newer versions.

That's true - I'll open a ticket for it for the team to handle separately

@ranrib ranrib merged commit e6c28fc into master Jul 5, 2021
@ranrib
Copy link
Member Author

ranrib commented Jul 5, 2021

🎉 This PR is included in version 1.70.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ranrib ranrib added the released label Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants