Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

feat(fastapi): added ignored endpoints #366

Merged
merged 2 commits into from
Jul 25, 2021
Merged

feat(fastapi): added ignored endpoints #366

merged 2 commits into from
Jul 25, 2021

Conversation

sagivr2020
Copy link
Member

No description provided.

@sagivr2020 sagivr2020 requested a review from a team as a code owner July 20, 2021 10:38
adavidai
adavidai reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@adavidai adavidai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
How about adding a test for the ignored endpoint functionality to the existing fastapi tests?

@sagivr2020
Copy link
Member Author

According to "run_tests.sh" file - pytest ignored FastAPI tests.
Therefore I added fastapi_example.py for testing.

adavidai
adavidai approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@adavidai adavidai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a ticket for enabling the tests back, once we do let's add this test as well

@sagivr2020 sagivr2020 merged commit fd9e5b8 into master Jul 25, 2021
@sagivr2020 sagivr2020 deleted the ignore-endpoints-fastapi-EP-7323 branch July 25, 2021 07:25
@ranrib
Copy link
Member

ranrib commented Jul 25, 2021

🎉 This PR is included in version 1.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adavidai adavidai adavidai approved these changes

@Alon-Katz Alon-Katz Awaiting requested review from Alon-Katz

@ronnathaniel ronnathaniel Awaiting requested review from ronnathaniel

Assignees
No one assigned
Labels
released size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sagivr2020 @ranrib @adavidai