This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Requests stream response support cs 3 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alon-Katz
reviewed
Aug 15, 2021
epsagon/events/requests.py
Outdated
| try: | ||
| return data.decode('utf-8') | ||
| except UnicodeDecodeError: | ||
| return str(data) |
There was a problem hiding this comment.
I would change this to a single return data at the end, then assign data to its value instead of returning at each step
Alon-Katz
approved these changes
Aug 15, 2021
|
🎉 This PR is included in version 1.73.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.