Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: os_uname check for wsl #543

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: os_uname check for wsl #543

merged 1 commit into from
Apr 18, 2024

Conversation

zaerald
Copy link
Contributor

@zaerald zaerald commented Apr 16, 2024

This PR resolves #542.

馃摑 Change Summary

  • Provide case-insensitive check for both of the sysname and release to handle the case with the following values:
sysname='Linux'
release='4.4.0-19041-Microsoft'

epwalsh
epwalsh approved these changes Apr 18, 2024
View reviewed changes
Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @zaerald!

@epwalsh epwalsh merged commit 6ffd196 into epwalsh:main Apr 18, 2024
7 checks passed
@zaerald zaerald deleted the fix/wsl-os-identifier branch April 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwalsh epwalsh epwalsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:ObsidianOpen in WSL uses xdg-open instead of wsl-open
2 participants
@zaerald @epwalsh