Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cairo-lang 0.8.0 #198

Merged
merged 5 commits into from Mar 14, 2022
Merged

Upgrade to cairo-lang 0.8.0 #198

merged 5 commits into from Mar 14, 2022

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented Mar 14, 2022

Upgrades to latest with minor refactoring to allow for easier testing in future as the old tests all went through the json per line i/o and as such formatted exceptions.

Sets max_fee = 0 at least for now, perhaps a better value for this is learned later. The same value is used by the cairo-lang test support as well by default.

This will most likely not support calling post 0.8.0 contracts, which would use the new additions.

Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@CHr15F0x CHr15F0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't noticed anything suspicious 👍

@koivunej koivunej merged commit d7bfc57 into main Mar 14, 2022
@koivunej koivunej deleted the upgrade_cairo_lang_0_8_0 branch March 14, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants