Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose.yml #487

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Create docker-compose.yml #487

merged 2 commits into from
Aug 5, 2022

Conversation

sven-hash
Copy link
Contributor

No description provided.

@sven-hash sven-hash requested a review from a team as a code owner July 30, 2022 07:50
docker-compose.yml Outdated Show resolved Hide resolved
@sven-hash
Copy link
Contributor Author

Changes made by adding a file pathfinder-var.env

@kkovaacs
Copy link
Contributor

kkovaacs commented Aug 2, 2022

Thanks for updating to use an .env file for the key.

However, your key's still in git history in this commit: 5fe2287

Would you mind rebasing your branch and fixing up the commit above with the "Update docker-compose.yml" commit following that? That would make sure that our git history doesn't contain your key.

@sven-hash
Copy link
Contributor Author

No need to remove it if you don't want to, it don't bother me it was an old key

Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this warrants inclusion and perpetual maintenance by the project, it seems this file can be quickly done by anyone just by reading the docker sections.

Is there some upside to using docker compose here I cannot see? If this is included for maintenance ... How do we test it? As far as I know, not one of the devs are using docker compose with pathfinder. Good thing is that using docker compose would handle testing the docker image manually.

example.pathfinder-var.env Outdated Show resolved Hide resolved
@sven-hash sven-hash requested a review from koivunej August 2, 2022 12:03
Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, though I am still quite unconvinced on how much this will help and the maintainership.

Don't worry about merging the main into the PR branch, we will rebase this before merging. Please make sure you have checked the "allow edits from maintainers" box.

Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raah should had approved to clear the status.

Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
@Mirko-von-Leipzig
Copy link
Collaborator

Ethereum tests fail due to this being an external PR, which doesn't have access to our secrets.

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 4f1f232 into eqlabs:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants