-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docker-compose.yml #487
Conversation
Changes made by adding a file |
Thanks for updating to use an However, your key's still in git history in this commit: 5fe2287 Would you mind rebasing your branch and fixing up the commit above with the "Update docker-compose.yml" commit following that? That would make sure that our git history doesn't contain your key. |
No need to remove it if you don't want to, it don't bother me it was an old key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this warrants inclusion and perpetual maintenance by the project, it seems this file can be quickly done by anyone just by reading the docker sections.
Is there some upside to using docker compose here I cannot see? If this is included for maintenance ... How do we test it? As far as I know, not one of the devs are using docker compose with pathfinder. Good thing is that using docker compose would handle testing the docker image manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, though I am still quite unconvinced on how much this will help and the maintainership.
Don't worry about merging the main into the PR branch, we will rebase this before merging. Please make sure you have checked the "allow edits from maintainers" box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raah should had approved to clear the status.
Co-authored-by: Joonas Koivunen <joonas@equilibrium.co>
Ethereum tests fail due to this being an external PR, which doesn't have access to our secrets. |
No description provided.