Point the TextStatistics package to the forked repo #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattonwebz
deleted the
william/570/php8-TextStatistics-prevent-possible-ValueError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users ran into issues where a ValueError was encountered when parsing for the reading grade level using the TextStatistics package.
I found that the package was not setup to handle this for PHP8. Since that package has not been updated in a long time, and has other open PRs waiting on merge for php8 compat I forked the package repo and have made some updates to it. The changes to the composer file in this PR pulls from the master branch in the fork. https://github.com/equalizedigital/textstatistics/
Changes to the TextStatistics package can also potentially solve issues where certain users are unable to complete pass 2 on the full site scan as well.
Fixes: #570