[Fix] Prevent settling the zero address from disrupting accounting

[kbrizzle]

Fixes report: sherlock-audit/2023-07-perennial-judging#62.

[github-actions]

[Payoff] Unit Test Code Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-payoff/contracts
PayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/interfaces
IPayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/payoff
Giga.sol	100%	100%	100%	100%
Kilo.sol	100%	100%	100%	100%
KiloPowerHalf.sol	100%	100%	100%	100%
KiloPowerTwo.sol	100%	100%	100%	100%
Mega.sol	100%	100%	100%	100%
MegaPowerTwo.sol	100%	100%	100%	100%
Micro.sol	100%	100%	100%	100%
MicroPowerTwo.sol	100%	100%	100%	100%
Milli.sol	100%	100%	100%	100%
MilliPowerHalf.sol	100%	100%	100%	100%
MilliPowerTwo.sol	100%	100%	100%	100%
Nano.sol	100%	100%	100%	100%
PowerHalf.sol	100%	100%	100%	100%
PowerTwo.sol	100%	100%	100%	100%

[github-actions]

[Payoff] Integration Test Code Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-payoff/contracts
PayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/interfaces
IPayoffFactory.sol	100%	100%	100%	100%
packages/perennial-payoff/contracts/payoff
Giga.sol	100%	100%	100%	100%
Kilo.sol	100%	100%	100%	100%
KiloPowerHalf.sol	100%	100%	100%	100%
KiloPowerTwo.sol	100%	100%	100%	100%
Mega.sol	100%	100%	100%	100%
MegaPowerTwo.sol	100%	100%	100%	100%
Micro.sol	100%	100%	100%	100%
MicroPowerTwo.sol	100%	100%	100%	100%
Milli.sol	100%	100%	100%	100%
MilliPowerHalf.sol	100%	100%	100%	100%
MilliPowerTwo.sol	100%	100%	100%	100%
Nano.sol	100%	100%	100%	100%
PowerHalf.sol	100%	100%	100%	100%
PowerTwo.sol	100%	100%	100%	100%

[github-actions]

[Extensions] Unit Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

82.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-extensions/contracts
MultiInvoker.sol	78.28%	72.86%	85.71%	80.37%	104, 143–144, 147–149, 151, 156, 222, 224, 233, 273, 273, 275, 278, 287, 287, 289, 292, 310, 312, 312, 312–313, 315, 320, 328–329, 331, 357, 360–362, 377, 382, 405, 77, 80–82
packages/perennial-extensions/contracts/interfaces
IMultiInvoker.sol	100%	100%	100%	100%
packages/perennial-extensions/contracts/types
TriggerOrder.sol	78.26%	62.50%	100%	94.44%	34–35, 61–68

[github-actions]

[Oracle] Unit Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

81.33%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-oracle/contracts
Oracle.sol	100%	100%	100%	100%
OracleFactory.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/interfaces
IOracle.sol	100%	100%	100%	100%
IOracleFactory.sol	100%	100%	100%	100%
IPythFactory.sol	100%	100%	100%	100%
IPythOracle.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/pyth
PythFactory.sol	57.14%	31.82%	77.78%	72%	100, 106, 117, 44, 53, 60–61, 75, 84, 89, 89–91, 91, 91–92, 92, 92–93, 93, 93, 95
PythOracle.sol	53.33%	35.42%	73.33%	63.16%	115–116, 122, 122, 122, 133, 138–139, 145, 149–150, 152, 152, 152, 155, 155, 155, 178, 178, 178, 183–184, 187, 190, 190, 190–191, 194–195, 195, 195, 197, 197, 197–198, 198, 198–200, 200, 200, 200, 200, 202–203, 242, 66, 70, 76, 81, 83, 93

[github-actions]

[Vault] Unit Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

31.77%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-vault/contracts
Vault.sol	0%	0%	0%	0%	103, 109–110, 118–119, 128, 130, 130, 130, 137, 139, 139, 139, 144, 144–145, 147–148, 148, 148, 151, 157, 157, 157–158, 158, 158, 160, 162–164, 171, 171–172, 174, 174, 174, 176–180, 185, 185–186, 188–189, 194, 194–197, 204, 204–206, 208–210, 223, 223–225, 227–230, 236–237, 237, 237–240, 242, 260, 260, 260–261, 261, 261, 264, 264, 264–266, 266, 266–268, 268, 268–270, 270, 270–272, 272, 272–274, 274, 274–275, 277, 277, 277, 280, 283–285, 288–290, 292, 306, 306, 306–308, 310, 310, 310, 315–316, 331, 335–338, 340, 346, 349, 349, 349, 352, 352, 352, 356–358, 371, 373, 373, 373, 373, 373, 375, 381–382, 382, 382–385, 385, 385–386, 393, 396, 398, 408, 422, 424–427, 429, 431–434, 437–438, 440–443, 446–447, 450–451, 454, 454, 454–456, 463, 463, 463–465, 472, 472, 472–474, 482, 482, 482, 484–487, 489, 489, 489, 489, 489, 491, 496, 503–505, 515–517, 519–521, 58, 58–59, 61–63, 69, 76, 83, 90, 97
VaultFactory.sol	0%	0%	0%	0%	23, 27, 27–28, 40, 40–42, 49–50
packages/perennial-vault/contracts/interfaces
IVault.sol	100%	100%	100%	100%
IVaultFactory.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/lib
StrategyLib.sol	0%	0%	0%	0%	101–104, 106, 108–109, 111–112, 126–128, 137, 64–66, 68, 70–73, 76, 80, 80, 80–81, 81, 85, 87
packages/perennial-vault/contracts/types
Account.sol	100%	100%	100%	100%
Checkpoint.sol	100%	100%	100%	100%
Mapping.sol	100%	100%	100%	100%
Registration.sol	100%	100%	100%	100%
VaultParameter.sol	100%	100%	100%	100%

[github-actions]

[Oracle] Integration Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

78.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-oracle/contracts
Oracle.sol	33.75%	30%	41.67%	34.21%	101, 103, 103, 103–104, 111, 114–115, 115, 115, 117, 122, 122, 122–124, 20, 29, 36, 36–37, 39–41, 48–49, 54, 59, 66, 66, 66–69, 69, 69–70, 72, 78, 96, 96, 96, 98–99, 99, 99
OracleFactory.sol	58.33%	40.63%	70%	73.33%	103–105, 105, 105–106, 112, 112, 112–113, 33, 41, 48, 48–50, 57–59, 62, 73–75, 78, 85, 94–95
packages/perennial-oracle/contracts/interfaces
IOracle.sol	100%	100%	100%	100%
IOracleFactory.sol	100%	100%	100%	100%
IPythFactory.sol	100%	100%	100%	100%
IPythOracle.sol	100%	100%	100%	100%
packages/perennial-oracle/contracts/pyth
PythFactory.sol	89.29%	72.73%	100%	100%	106, 117, 44, 53, 60, 89
PythOracle.sol	98.33%	95.83%	100%	100%	133, 229

[github-actions]

[Core] Integration Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

92.60%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial/contracts
Market.sol	76.17%	57%	88.57%	85.28%	100–101, 106, 113, 120–122, 131, 133, 133, 133–134, 134, 134–136, 136, 136–137, 137, 137, 139, 146, 146, 146, 148–150, 155, 157–158, 160–161, 252–254, 393, 438, 477–478, 478, 478, 478, 487–488, 493–494, 496–497, 501, 507–508, 508, 517, 521, 532, 538–539, 556–557, 60, 605, 610, 83, 92, 99, 99
MarketFactory.sol	69.70%	50%	83.33%	80%	37, 48, 57–58, 64, 66, 72, 75–76
packages/perennial/contracts/interfaces
IMarket.sol	100%	100%	100%	100%
IMarketFactory.sol	100%	100%	100%	100%
IOracleProvider.sol	100%	100%	100%	100%
IOracleProviderFactory.sol	100%	100%	100%	100%
IPayoffProvider.sol	100%	100%	100%	100%
packages/perennial/contracts/types
Global.sol	78.57%	50%	100%	100%	114–125
Local.sol	80%	56.25%	83.33%	95.65%	127–132, 89, 97
MarketParameter.sol	69.57%	40.91%	100%	95%	112, 114–115, 117, 119, 121, 121, 121, 121, 133–137
OracleVersion.sol	100%	100%	100%	100%
Order.sol	88.46%	70%	100%	100%	73, 79, 98
Position.sol	88.52%	60%	96.88%	98.33%	200, 218, 275, 443–452
ProtocolParameter.sol	75%	50%	100%	100%	59–60, 66–70
RiskParameter.sol	73.91%	50%	100%	100%	133, 138, 143, 145, 150, 152, 154, 156, 166–169
Version.sol	90.18%	70.59%	100%	98.57%	192–193, 361–369

[github-actions]

[Vault] Integration Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

98.92%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-vault/contracts
Vault.sol	97.35%	95.95%	96.88%	98.10%	194, 194–197, 277
VaultFactory.sol	85.71%	50%	100%	100%	27, 40
packages/perennial-vault/contracts/interfaces
IVault.sol	100%	100%	100%	100%
IVaultFactory.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/lib
StrategyLib.sol	100%	100%	100%	100%
packages/perennial-vault/contracts/types
Account.sol	82.86%	50%	100%	100%	126–131
Checkpoint.sol	88.64%	68.75%	100%	100%	132, 186, 224–231
Mapping.sol	95.12%	80%	100%	100%	100, 95
Registration.sol	81.82%	50%	100%	100%	41–42
VaultParameter.sol	87.50%	50%	100%	100%	31

[github-actions]

[Core] Unit Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

99.76%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial/contracts
Market.sol	99.66%	99%	100%	100%	83
MarketFactory.sol	100%	100%	100%	100%
packages/perennial/contracts/interfaces
IMarket.sol	100%	100%	100%	100%
IMarketFactory.sol	100%	100%	100%	100%
IOracleProvider.sol	100%	100%	100%	100%
IOracleProviderFactory.sol	100%	100%	100%	100%
IPayoffProvider.sol	100%	100%	100%	100%
packages/perennial/contracts/types
Global.sol	100%	100%	100%	100%
Local.sol	95.56%	100%	83.33%	95.65%	97
MarketParameter.sol	100%	100%	100%	100%
OracleVersion.sol	100%	100%	100%	100%
Order.sol	100%	100%	100%	100%
Position.sol	100%	100%	100%	100%
ProtocolParameter.sol	100%	100%	100%	100%
RiskParameter.sol	100%	100%	100%	100%
Version.sol	100%	100%	100%	100%

[github-actions]

[Extensions] Integration Test Coverage Report

Coverage after merging britz-fix-vault-0-settle into main will be

99.20%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
packages/perennial-extensions/contracts
MultiInvoker.sol	97.47%	92.86%	100%	100%	156, 275, 289, 357, 377
packages/perennial-extensions/contracts/interfaces
IMultiInvoker.sol	100%	100%	100%	100%
packages/perennial-extensions/contracts/types
TriggerOrder.sol	89.13%	83.33%	100%	94.44%	34–35, 61–63