This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
chore: refactor sync job #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks up the sync job into smaller steps so that if fetching the spec succeeds, but patching the spec or generating the code fails, we can still make use of whatever succeeded. The new sync job first fetches and commits the latest spec; if that succeeds, then it applies spec patches and commits the patched spec; if that succeeds, then it regenerates the code. When opening a PR, the sync job now checks if either patching or generating failed; if there was a failure, it creates the PR in draft status and adds a comment indicating which step failed.
displague
approved these changes
Jun 5, 2023
|
This PR is included in version 0.9.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks up the sync job into smaller steps so that if fetching the spec succeeds, but patching the spec or generating the code fails, we can still make use of whatever succeeded.
The new sync job first fetches and commits the latest spec; if that succeeds, then it applies spec patches and commits the patched spec; if that succeeds, then it regenerates the code.
When opening a PR, the sync job now checks if either patching or generating failed; if there was a failure, it creates the PR in draft status and adds a comment indicating which step failed.