Rebrand rename driver #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Feb 12, 2021
displague
reviewed
Feb 12, 2021
displague
reviewed
Feb 12, 2021
displague
reviewed
Feb 12, 2021
|
@jmarhee I pushed up fixes for my last bit of feedback. If we merge this we will want to get the repo rename in immediately afterward. Now that I've looked at the code a little closer, I'm wondering if Users can alias drivers, so if I'm ok with I'll approve this PR since it is passing tests and I've taken a closer look. I'll leave it to you to offer a final review and merge. |
displague
approved these changes
Feb 18, 2021
…cessfully provisioned a machine Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com> Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com> Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
…e would expect from an environment variable-- this isn't breaking example, but as a debug step is clearer/more consistent. Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I began updating this package in conjunction with the Rancher UI driver, which for whatever reason, was assuming the driver name would be one word rather than two, so I elected to use
metalrather thanequinix-metal-- this would be a trivial thing to revert, if we prefer the full name, but opening the PR using what I know to be a working use of the rebranded name and providing the context.Fixes #56