Implement Metros and update the default OS, plan, and location #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
jmarhee
suggested changes
Apr 23, 2021
pkg/drivers/metal/metal.go
Outdated
| @@ -22,6 +23,8 @@ import ( | |||
| const ( | |||
| dockerConfigDir = "/etc/docker" | |||
| consumerToken = "24e70949af5ecd17fe8e867b335fc88e7de8bd4ad617c0403d8769a376ddea72" | |||
| defaultOS = "ubuntu_20_04" | |||
| defaultMetro = "DC" | |||
There was a problem hiding this comment.
The metro should be lower-cased:
$ docker-machine create sloth --driver metal --metal-api-key=$API_KEY --metal-project-id=$PROJECT --metal-plan "baremetal_0" --metal-metro-code "DC"
Running pre-create checks...
Error with pre-create check: "metal requires a valid metro"
Runs as expected with "dc" from the CLI
There was a problem hiding this comment.
I intended to change the default plan from baremetal_0 to c3.small.x86 so that the defaults would accommodate more users (new users).
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
baremetal_0 is an alias for t1.small.x86 which is not available to new Equinix Metal users. c3.small.x86 is the smallest plan available to all users. Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces metros and updates the defaults to those available to all users.
Fixes #60
Fixes #61