Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous PR breaks the CLI #20

Closed
jasmingacic opened this issue Aug 5, 2019 · 2 comments · Fixed by #21
Closed

Previous PR breaks the CLI #20

jasmingacic opened this issue Aug 5, 2019 · 2 comments · Fixed by #21

Comments

@jasmingacic
Copy link
Contributor

Changes submitted here are breaking the CLI.
It does not allow users to use only environment variables, but only config files. This does not comply with the instructions https://github.com/packethost/packet-cli#authentication
@jasmingacic
Copy link
Contributor Author 

PACKET_TOKEN=$PACKET_TOKEN packet plan get 
Unable to read in config file, check the file path and defaults (./packet-cli.{yaml,json} in user home directory) and try again

@jasmingacic
Copy link
Contributor Author

I've tested one of the release binaries https://github.com/packethost/packet-cli/releases/tag/0.0.2 and it works fine with either environment variable or config file.
The PR #17 should be reverted as it doesn't make any sense.

@alexeldeib alexeldeib mentioned this issue Aug 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow failure reading config file alexeldeib/packet-cli
1 participant
@jasmingacic