Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-json config in homedir #17

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Conversation

alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented Jul 12, 2019

Fixes #14

Adds err check on file read for config initialization.

@t0mk
Copy link
Contributor

t0mk commented Jul 12, 2019

thanks for the PR @alexeldeib, looksgood!

@t0mk t0mk merged commit 861c954 into equinix:master Jul 12, 2019
@jasmingacic
Copy link
Contributor

jasmingacic commented Aug 5, 2019

This fix is breaking the CLI each command that is ran without a config file results in this:

packet plan get 
Unable to read in config file, check the file path and defaults (./packet-cli.{yaml,json} in user home directory) and try again.

It seems even when config file is not present it overrides the environment variable.

@jasmingacic
Copy link
Contributor

jasmingacic commented Aug 5, 2019

Also the message is incorrect. The file created should be .packet-cli.{yaml,json} not ./packet-cli.{yaml,json}
This does not reflect what users are supposed to do according to the docs https://github.com/packethost/packet-cli#authentication

jasmingacic pushed a commit to TheAntColony/packet-cli that referenced this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml config file not autodetected
3 participants