return error codes when errors are encountered #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
force-pushed
the
run-with-error-handling
branch
from
6c90aae
to
92d8ff8
Compare
This was referenced Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
RunEinstead ofRunso that errors that are currently only printed are reported as errors to Cobra. This will allow Cobra to emit return codes when errors are encountered.Errors previously reported as "Client Error" now report a more contextual message "Could not get Thing", accompanied by a more detailed client error.
A few commend blocks and strings were updated to use the correct command name.
Some of these problems and improvements were brought to light in #66. By introducing these changes here, #66 will be easier to review.