Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID field casing convention in client.go #15

Open
displague opened this issue Mar 29, 2022 · 0 comments
Open

Fix ID field casing convention in client.go #15

displague opened this issue Mar 29, 2022 · 0 comments
Labels
breaking change A breaking change will be introduced enhancement New feature or request

Comments

@displague
Copy link
Member

ID/UUID appears to be the convention we've been using in ne-go. We have many examples of ...UUID, ...ID, IP..., and MAC....

We have some public type definitions that don't fit the current convention.

$ git grep -n  -e Id -e Uuid client.go rest_client.go
client.go:249:  MgmtAclTemplateUuid *string
client.go:263:  WanInterfaceId      *string
client.go:435:  ClusterId          *string
client.go:446:  LicenseFileId       *string

This issue is a continuation of #13 where the internal representation of these types was updated.

Addressing this issue may constitute a breaking change so it was deferred from #13.

Originally posted by @displague in #12 (comment)

@displague displague added enhancement New feature or request breaking change A breaking change will be introduced labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A breaking change will be introduced enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant