-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
equinix_metal_connection field vlans should be forcenew #222
Comments
@ocobleseqx and @displague we discussed this issue earlier today, and I believe we concluded that it is possible to update VLANs for a shared connection, so we don't have to force recreate a connection when the One alternative I suggested, which could allow us to avoid recreating a shared metal connection when |
VLAN must remain optional since they can just be defined for This conversation took place because in the API there are different endpoints to create the SC and to update a VC, and we try to avoid hidden magic in the behavior of the terraform provider, and each resource must be a representation of an object/API endpoint. In this case, I think that recreating the connection instead of just updating the VLAN in the pre-created VC can cause several difficulties for the end user, for example, there are customers where the Metal resources and Fabric resources are managed by different departments or even different companies. However, that can backfire for users coming from the API and will also work against our journey of achieving an auto-generated terraform provider, where all resources will be just a representation of the API specs. To sum up, in my opinion, I'd go ahead with this change and add the In addition to that, we don't have enough information today about the limitations and inconveniences that can cause a user forcing the recreation of the connection resources (on both Metal and Fabric sides). That is something we can change and work on in the future once we receive feedback or any special requests. |
The more I think about this, the more I'm concerned about adopting
|
VLANS field is only used with |
Superseded by #272 |
) The Metal API was recently updated to change the behavior of shared interconnections as follows: - VLANs must be specified at creation for shared connections - VLANs cannot be updated for shared connections This updates the connection resource to align with the new API behavior so that users can catch configuration errors earlier. Note this rolls back #273, which was written to address #222. This also includes a fix for #595
The
vlans
field ofequinix_metal_connection
can not be updated. If a user changes this field the resource must be recreated.What happens today is the change is silently updated in state without making remote changes.
https://github.com/equinix/terraform-provider-equinix/blob/master/equinix/resource_metal_connection.go#L141
The text was updated successfully, but these errors were encountered: