Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing fabric connection schema for port 2 network connection #478

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

srushti-patl
Copy link
Contributor

This fix Includes:

  • Added EVPLAN_VC,EPLAN_VC to fabric connection schema
  • Marked project_id as an optional parameter

@codecov-commenter
Copy link

Codecov Report

Attention: 381 lines in your changes are missing coverage. Please review.

Comparison is base (26b2f3d) 60.11% compared to head (5dd9d8e) 59.71%.
Report is 85 commits behind head on main.

Files Patch % Lines
equinix/fabric_mapping_helper.go 0.00% 68 Missing ⚠️
equinix/resource_fabric_connection.go 0.00% 40 Missing ⚠️
equinix/resource_fabric_cloud_router.go 0.00% 32 Missing ⚠️
equinix/resource_fabric_service_profile.go 0.00% 14 Missing ⚠️
equinix/resource_fabric_routing_protocol.go 0.00% 13 Missing ⚠️
equinix/resource_metal_device.go 76.36% 10 Missing and 3 partials ⚠️
equinix/resource_metal_organization_member.go 27.77% 13 Missing ⚠️
equinix/resource_metal_project.go 52.63% 8 Missing and 1 partial ⚠️
equinix/resource_metal_vlan.go 43.75% 8 Missing and 1 partial ⚠️
equinix/resource_ecx_l2_connection.go 38.46% 8 Missing ⚠️
... and 39 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   60.11%   59.71%   -0.41%     
==========================================
  Files          99       97       -2     
  Lines       20045    19825     -220     
==========================================
- Hits        12051    11839     -212     
- Misses       7691     7695       +4     
+ Partials      303      291      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it.

@srushti-patl srushti-patl merged commit 4ac0983 into main Dec 11, 2023
4 of 5 checks passed
@srushti-patl srushti-patl deleted the CXF-81881 branch December 11, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants