Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary wrappers for getting a random string or int #481

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Dec 8, 2023

Some of the Network Edge tests were using randInt and randString to generate random integers and strings. The only thing each function does is call an upstream function; this replaces all calls to those functions with direct calls to the upstream (which matches what we do in other tests) and removes the unnecessary wrappers.

@ctreatma ctreatma merged commit 3f63566 into main Dec 11, 2023
4 of 5 checks passed
@ctreatma ctreatma deleted the clean_up_test_helpers branch December 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants