fix: Updating Fabric Service Profile resource mapping functions #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
thogarty
requested changes
Feb 21, 2024
srushti-patl
changed the title
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
…-Resource-Update' into CXF-86927-Fabric-Service-Profile-Resource-Update
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 42.08% 43.81% +1.72%
==========================================
Files 98 98
Lines 18401 18397 -4
==========================================
+ Hits 7744 8060 +316
+ Misses 10453 10102 -351
- Partials 204 235 +31 ☔ View full report in Codecov by Sentry. |
thogarty
requested changes
Feb 22, 2024
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
thogarty
requested changes
Feb 23, 2024
| @@ -1044,44 +1039,44 @@ func accessPointTypeConfigToTerra(spAccessPointTypes []v4.ServiceProfileAccessPo | |||
| return mappedSpAccessPointTypes | |||
| } | |||
|
|
|||
| func apiConfigToFabric(apiConfigl []interface{}) v4.ApiConfig { | |||
| if apiConfigl == nil { | |||
| func apiConfigToFabric(apiConfigs []interface{}) v4.ApiConfig { | |||
There was a problem hiding this comment.
Marking this method for live code review.
| } | ||
| return ports | ||
| return schemaPortRes | ||
| } | ||
|
|
||
| func virtualDevicesToFabric(schemaVirtualDevices []interface{}) []v4.ServiceProfileAccessPointVd { |
There was a problem hiding this comment.
Marking method for live code review.
| @@ -1208,14 +1203,14 @@ func metrosToFabric(schemaMetros []interface{}) []v4.ServiceMetro { | |||
| return []v4.ServiceMetro{} | |||
| } | |||
| var metros []v4.ServiceMetro | |||
There was a problem hiding this comment.
Marking method for live code review.
| } | ||
|
|
||
| func authenticationKeyToFabric(authenticationKeyl []interface{}) v4.AuthenticationKey { | ||
| if authenticationKeyl == nil { | ||
| func authenticationKeyToFabric(authenticationKeys []interface{}) v4.AuthenticationKey { |
There was a problem hiding this comment.
Marking method for live code review.
| psTitle := processStep.(map[string]interface{})["title"].(interface{}).(string) | ||
| psSubTitle := processStep.(map[string]interface{})["sub_title"].(interface{}).(string) | ||
| psDescription := processStep.(map[string]interface{})["description"].(interface{}).(string) | ||
| processSteps = append(processSteps, v4.ProcessStep{ | ||
| processStepRes[index] = v4.ProcessStep{ |
There was a problem hiding this comment.
Marking variable naming for live code review.
…-Resource-Update' into CXF-86927-Fabric-Service-Profile-Resource-Update
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
srushti-patl
temporarily deployed
to
internal
GitHub Actions
Inactive
thogarty
approved these changes
Feb 23, 2024
srushti-patl
deleted the
CXF-86927-Fabric-Service-Profile-Resource-Update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed mapping functions in resource_fabric_service_profile.go and fabric_common_mapping_helpers.go