Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix connection update bug on project_id #583

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

thogarty
Copy link
Contributor

  • Update Connection's project attribute to be optional/computed
    • It being set from the API response, but not being computed would cause it to be reverted to null during subsequent terraform plans/applies when there was never an explicit project set in the config.
  • Updated Connection SetMap entry to not set nil values from API response
  • Updated projectToFabric and projectToTerra methods to remove code bloat
  • Updating handling of project config in connection and network resources

@thogarty thogarty changed the title bug: Fix connection update bug on project_id fix: Fix connection update bug on project_id Feb 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a2797d8) 63.11% compared to head (8260941) 45.73%.
Report is 59 commits behind head on main.

Files Patch % Lines
equinix/resource_fabric_connection.go 93.18% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #583       +/-   ##
===========================================
- Coverage   63.11%   45.73%   -17.38%     
===========================================
  Files          94       93        -1     
  Lines       18250    18164       -86     
===========================================
- Hits        11519     8308     -3211     
- Misses       6299     9724     +3425     
+ Partials      432      132      -300     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thogarty thogarty added the area/resources/fabric Issues related to Fabric and ECX APIs label Feb 21, 2024
Copy link
Contributor

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thogarty thogarty merged commit 85b0f02 into main Feb 22, 2024
7 of 10 checks passed
@thogarty thogarty deleted the CXF-86140-fabric-update-bug branch February 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resources/fabric Issues related to Fabric and ECX APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants