feat: Introduce Optional field (diverseFromDeviceUuid )in create device - Single(non HA) #592
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 42.09% 42.07% -0.02%
==========================================
Files 98 98
Lines 18397 18412 +15
==========================================
+ Hits 7744 7747 +3
- Misses 10449 10459 +10
- Partials 204 206 +2 ☔ View full report in Codecov by Sentry. |
| @@ -298,6 +299,9 @@ device configurations. See [Secondary Device](#secondary-device) below for more | |||
| If not specified, default will be INTERNET-ACCESS | |||
| * `project_id` - (Optional) Unique Identifier for the project resource where the device is scoped to.If you | |||
| leave it out, the device will be created under the default project id of your organization. | |||
| * `diverse_device_id` - (Optional) Unique ID of an existing device. | |||
| Use this field to let Equinix know if you want your new device to be in a different location from any existing virtual | |||
| device. This field is only meaningful for single devices. | |||
|
|
|||
There was a problem hiding this comment.
the diverse_device_name field must be documented
There was a problem hiding this comment.
Both fields must also be added to the docs/data-sources/equinix_network_device.md attributes list.
There was a problem hiding this comment.
addressed them, pls check and let me know @displague
There was a problem hiding this comment.
The fields should be added here in the datasource documentation:
https://github.com/kpdhulipala/terraform-provider-equinix/blame/NFV-27633/docs/data-sources/equinix_network_device.md#L31
There was a problem hiding this comment.
sorry, I got it now, added them in data source equinix_network_device.md
…key create and get APIs
…key create and get APIs
…key create and get APIs
…key create and get APIs
kpdhulipala
force-pushed
the
NFV-27633
branch
from
ea2f117
to
5daf295
Compare
equinix/resource_network_device.go
Outdated
| neDeviceSchemaNames["DiverseFromDeviceName"]: { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Optional: true, |
There was a problem hiding this comment.
Optional field should be removed here since it's purely a computed field. We are not sending this field as part of request.
… diverse device uuid, name
Signed-off-by: kpdhulipala <84343462+kpdhulipala@users.noreply.github.com>
kpdhulipala
had a problem deploying
to
external
GitHub Actions
Failure
feat: Introduce Optional field (diverseFromDeviceUuid )in create device - Single/non HA
Closes: ne-go module PR- equinix/ne-go#31
https://developer.equinix.com/catalog/network-edgev1#operation/createVirtualDeviceUsingPOST