Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Network Edge BGP Acceptance Tests to use fabric resources(fabric connection and service profile) #710

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: Update Network Edge BGP Acceptance Tests to use fabric resources(fabric connection and service profile) #710

merged 1 commit into from
Jun 26, 2024

Conversation

kpdhulipala
Copy link
Contributor

feat: Update Network Edge BGP Acceptance Tests to use fabric resources(fabric connection and service profile)

@kpdhulipala kpdhulipala requested a review from a team as a code owner June 25, 2024 21:22
@kpdhulipala kpdhulipala mentioned this pull request Jun 25, 2024
Merged
@ctreatma
Copy link
Contributor

These tests don't run in CI at the moment, and I'm not exactly sure what's needed to run them locally. If you and your team are able to run these tests and they work with these updates, that is enough for now.

The CODEOWNERS configuration in this repo means that only a review from @equinix/governor-ne-network-edge-engineering can make this PR mergeable.

@kpdhulipala
Copy link
Contributor Author

These tests don't run in CI at the moment, and I'm not exactly sure what's needed to run them locally. If you and your team are able to run these tests and they work with these updates, that is enough for now.

The CODEOWNERS configuration in this repo means that only a review from @equinix/governor-ne-network-edge-engineering can make this PR mergeable.

We need to refactor these tests as they are dependent on V3 resources- ecx l2 connection and equinix_ecx_l2_sellerprofile and with the changes mentioned in below MR, I'm able to run them with refactored code.
https://github.com/equinix/terraform-provider-equinix/pull/683/files#diff-1a6d9356dadc63745ca8780c874574545fb9a579ea616a8b47d806b95f7a979f

rling-equinix
rling-equinix approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rling-equinix rling-equinix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rling-equinix rling-equinix merged commit 3072853 into equinix:main Jun 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rling-equinix rling-equinix rling-equinix approved these changes

@yvikrant yvikrant yvikrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpdhulipala @ctreatma @rling-equinix @yvikrant