chore(ci): rename acctest workflow since it only applies to Metal #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
force-pushed
the
acctest-restructure
branch
from
58d26cb
to
71e4c84
Compare
ctreatma
force-pushed
the
acctest-restructure
branch
from
71e4c84
to
3fc844a
Compare
displague
reviewed
Jul 11, 2024
| @@ -110,7 +110,7 @@ jobs: | |||
| METAL_AUTH_TOKEN: ${{ secrets.METAL_AUTH_TOKEN }} | |||
| TF_ACC_METAL_DEDICATED_CONNECTION_ID: ${{ secrets.TF_ACC_METAL_DEDICATED_CONNECTION_ID }} | |||
| run: | | |||
| go test ./... -v -coverprofile coverage.txt -covermode=atomic -count 1 -parallel 8 -run "(Metal)|(Provider)|(Migration)" -timeout 180m | |||
| go test ./... -v -coverprofile coverage.txt -covermode=atomic -count 1 -parallel 8 -run "(Metal)" -timeout 180m | |||
There was a problem hiding this comment.
I was curious if there were tests like FCR...Metal. There are not.
$ git grep 'func\ Test.*Metal' | grep -E -v -e 'TestAcc((Pre)?Check)?(?i:(Data|Re)Source)?Metal'
internal/resources/metal/vlan/datasource_test.go:func TestMetalVlan_matchingVlan(t *testing.T) {
displague
reviewed
Jul 11, 2024
| @@ -50,7 +50,7 @@ jobs: | |||
| run: go build -v . | |||
|
|
|||
| - name: TF tests | |||
| run: go test -v --coverprofile coverage.txt -covermode=atomic -parallel 4 $(go list ./... |grep -v 'tests') | |||
| run: go test -v --coverprofile coverage.txt -covermode=atomic -parallel 4 ./... | |||
There was a problem hiding this comment.
Perhaps the intent of the old code was to ignore coverage of the tests themselves (or testing_helpers). Should be fine.
There was a problem hiding this comment.
The go list subcommand was added to avoid running the terragrunt tests in the tests directory since there was no way to make them work in CI. Those tests have since been deleted, so the subcommand was effectively a no-op after that.
displague
approved these changes
Jul 11, 2024
|
This PR is included in version 2.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.