Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST guidelines #82

Merged
merged 15 commits into from
Apr 21, 2020
Merged

REST guidelines #82

merged 15 commits into from
Apr 21, 2020

Conversation

oyron
Copy link
Collaborator

@oyron oyron commented Mar 25, 2020

No description provided.

oyron and others added 6 commits March 6, 2020 14:01
* changelog v1.1

* API Security

* update changelog v1.1

* fixed owasp links

* CHANGELOG v1.1.1

Co-authored-by: oyron <oyron@statoil.com>
@mahewitt
Copy link

mahewitt commented Apr 3, 2020

Not sure if this is the correct page to add it, but does Equinor have any thought on oData - https://www.odata.org/

Copy link
Contributor

@joelmheim joelmheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selve beskrivelsen av REST er jo grei, så dette er et bra tillegg til strategien.
Jeg skulle likevel ønsket meg litt mer fokus på den synkrone naturen til HTTP (og dermed REST), i forhold til asynkrone mekanismer som man vil trenge i event drevne systemer. Jeg tror GraphQL er en bedre match med slike arkitekturer. Tror dette er et tema vi bør ta opp i kjernegruppen ved en senere anledning for å se hvordan vi kan inkludere det i strategien.

@jonatanP1993
Copy link

After reading through the document, and the links in the document, I find the document very well structured and informative.

My only concern is how to enforce the guidelines, but that's a different discussion.

@oyron
Copy link
Collaborator Author

oyron commented Apr 16, 2020

Not sure if this is the correct page to add it, but does Equinor have any thought on oData - https://www.odata.org/

@mahewitt - I believe it is important that we build our REST APIs in a consistent way, to facilitate adoption and make building competence and doing reviews easier. Hence, we should choose one main approach for the APIs we build. The REST design guidelines are based on industry standard conventions for REST APIs. OData is a different flavor of REST, that we often encounter in products from Microsoft and SAP, but is generally less common in the industry. Choosing the most common/industry standard approach has less risk for Equinor, wrt competence, longevity, etc.
For out-of-the box APIs or in special cases like where the tooling provides the API, OData could be the best option. It is classified as careful in TLC.

@oyron
Copy link
Collaborator Author

oyron commented Apr 16, 2020

Selve beskrivelsen av REST er jo grei, så dette er et bra tillegg til strategien.
Jeg skulle likevel ønsket meg litt mer fokus på den synkrone naturen til HTTP (og dermed REST), i forhold til asynkrone mekanismer som man vil trenge i event drevne systemer. Jeg tror GraphQL er en bedre match med slike arkitekturer. Tror dette er et tema vi bør ta opp i kjernegruppen ved en senere anledning for å se hvordan vi kan inkludere det i strategien.

Absolutely agree that we should discuss GraphQL and async APIs and look into how we should include this in the strategy.

@oyron oyron marked this pull request as ready for review April 21, 2020 08:27
@oyron oyron merged commit 8031517 into vNext Apr 21, 2020
@oyron oyron deleted the rest-guidelines branch April 21, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants