feat: Inj_Valve_fix #113
feat: Inj_Valve_fix #113
Conversation
| @@ -635,6 +635,10 @@ def get_device(df_well: pd.DataFrame, df_device: pd.DataFrame, device_type: Devi | |||
| # rescale the Cv | |||
| # because no scaling factor in WSEGVALV | |||
| df_well[Headers.CV_DAR] = -df_well[Headers.CV_DAR] / df_well[Headers.SCALING_FACTOR] | |||
| elif device_type == "INJV": | |||
There was a problem hiding this comment.
Make oneliner, ie:
'# rescale the CV, because there are no scaling factor in WSEGVALV.'
This can be done in all occasions or replace the three to one time at the top.
| @@ -126,6 +126,12 @@ class Headers: | |||
| GHF_LCF_DAR = "GHF_LCF_DAR" | |||
| GHF_HCF_DAR = "GHF_HCF_DAR" | |||
|
|
|||
| CV_INJV = "CV_INJV" | |||
| AC_PRIMARY = "AC_PRIMARY" | |||
| AC_SECONDARY = "AC_SECONDARY" | |||
There was a problem hiding this comment.
Not a fan of this names, but it's ok for now
| @@ -132,6 +132,17 @@ def __init__( | |||
| {"-" * 100}{self.newline1}""" | |||
|
|
|||
| self.print_wsegdarinit = self.print_wsegdar | |||
| self.print_wseginjv = f"""\ | |||
| {'-' * 100} | |||
| -- This is how we model Injection Valve technology using sets of ACTIONX keywords. | |||
There was a problem hiding this comment.
repeating information.
Should the line maybe be?
-- The segment dP curves changes according to the segment water rate and segment -
-- pressure drop at downhole condition.
instead?
| def make_wseginjv(self) -> None: | ||
| """Print WSEGINJV to file.""" | ||
| if self.df_wseginjv.shape[0] > 0: | ||
| self.print_wseginjv += po.print_wseginjv(self.df_wseginjv, self.iwell + 1) + "\n" |
There was a problem hiding this comment.
Not super fan how this is written, maybe a TODO on refactoring this selv update stuff?
But that is not relevant for this PR.
| @@ -412,7 +430,12 @@ def fix_printing(self) -> None: | |||
| self.print_wsegdar = "" | |||
| else: | |||
| self.print_wsegdar += self.newline1 | |||
| # if no DAR then dont print | |||
| # if no Injection Valve then dont print | |||
There was a problem hiding this comment.
"If there are no injection valve dont print update the print statement."
Maybe reduntant comment,
| well_name = df_wseginjv[Headers.WELL].iloc[idx] | ||
| action += f" ASSIGN SUVTRIG {well_name} {segment_number} 0 /\n" | ||
| action += "/\n\n" | ||
| iaction = 1 |
There was a problem hiding this comment.
Use the number 1 directly?
| water_segment_rate_cutoff = df_wseginjv[Headers.WR_CF_INJV].iloc[idx] | ||
| pressure_drop_cutoff = df_wseginjv[Headers.PRD_CF_INJV].iloc[idx] | ||
|
|
||
| iaction = 0 |
There was a problem hiding this comment.
should not be set in every loop
| print_df = df_wseginjv[df_wseginjv[Headers.SEG] == segment_number] | ||
| print_df = print_df[header[iaction]] # type: ignore | ||
| header_string = Keywords.WSEGVALV + "\n--" | ||
| for item in header[iaction]: |
There was a problem hiding this comment.
this loop seems unnecessary
| print_df += f"\nUDQ\n ASSIGN SUVTRIG {well_name} {segment_number} 1 /\n/\n" | ||
| action += print_df + "\nENDACTIO\n\n" | ||
|
|
||
| return action |
There was a problem hiding this comment.
This function is a bit long
| Headers.PRD_CF_INJV, | ||
| ] | ||
|
|
||
| # Fix table format |
There was a problem hiding this comment.
| # Fix table format | |
| # Fix table format. |
Description
feat: Injection valve second run
Why
Add injection valve and fix commit issue #112
How
How the change is implemented (if it's not self evident in the diff)
Close: #111
Checklist:
Before submitting this PR, please make sure: