Snackbar #332
Merged
Snackbar #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnys
requested changes
Jun 22, 2020
| > | ||
| Your changes was saved | ||
| <SnackbarAction> | ||
| <Button variant="ghost">Undo</Button> |
There was a problem hiding this comment.
The button text is a bit hard to read. In Figma the undo button uses /* Infographic Primary/Moss Green 34 */ as the color – I think we should override the default color with a <StyledButton (but keep the hover style).
There was a problem hiding this comment.
If you write the css like this it won’t affect the hover state. Maybe also write a comment in the story why we’re doing it like that.
const StyledButton = styled(Button)`
:not(:hover) {
color: ${buttonColor};
}
`There was a problem hiding this comment.
We have to add a prop to the ghost-button to make the text lighter on negative background, but until we do that we have to show the users how to fix that themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #169