feat(datepicker): add datepicker to eds #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusijs
force-pushed
the
feature/RHENRI/date-picker
branch
from
3d75114
to
aebb62d
Compare
yusijs
force-pushed
the
feature/RHENRI/date-picker
branch
from
aebb62d
to
816c2e4
Compare
|
There are probably still some stuff that needs to be worked out / changed, but need to draw a line somewhere on changing the functionality. What I've added here is stable (you know.. ish), and I don't see any changes that I would need to do, so would be good to get reviews on it |
- Describe toggle - Add aria-live to header
- Add abbr for name of day of week
There was a problem hiding this comment.
Great work @yusijs . I added some comments, but in total I think this is a good solution.
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DateRangePicker.spec.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/DateRangePicker.tsx
Outdated
Show resolved
Hide resolved
|
Made some changes on @BirteThornquist's request (spacing, header/footer layout). We agreed that there are no major / show-stopping design flaws, and the component can go out as-is and be adjusted in future releases (same process as with the DataGrid) |
Caused issues w/ header/footer popover. Removed to save time
|
Couldn't help myself, added a year-picker (verified design w/ @BirteThornquist) |
torleifhalseth
previously requested changes
Apr 17, 2024
packages/eds-core-react/src/components/Datepicker/fields/Toggle.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/calendars/CalendarHeader.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/calendars/CalendarGrid.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/utils/useConvertedValidationFunctions.ts
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/calendars/Calendar.tsx
Outdated
Show resolved
Hide resolved
packages/eds-core-react/src/components/Datepicker/calendars/Calendar.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create date / date-range picker for EDS
Closes #3385
Todo: